[
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859662#comment-16859662
]
Lucene/Solr QA commented on SOLR-12870:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} SOLR-12870 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12870 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12943988/SOLR-12870.master.1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/428/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Use StandardCharsets instead of String values
> ---------------------------------------------
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
> Issue Type: Improvement
> Reporter: Peter Somogyi
> Priority: Minor
> Attachments: SOLR-12870.master.1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch
> block caused by UnsupportedEncodingException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
