vthacker commented on issue #707: Use append() when StringBuilder is being used, instead of regular concat. URL: https://github.com/apache/lucene-solr/pull/707#issuecomment-500317963 Overall this looks good! I think we should not make these changes for the test files? Also can you please add an entry under `lucene/CHANGES.txt` under the 8.2 section. You might want to add an "Other" section like 8.1 . For the Lucene-NNNN can you just prefix the PR number for now. I'm going to check if that's going to be encouraged going forward or not on this [thread](http://mail-archives.apache.org/mod_mbox/lucene-dev/201906.mbox/%3c00414c73-f0ce-4286-9f48-774d45e21...@cominvent.com%3E)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
