[
https://issues.apache.org/jira/browse/SOLR-13533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859850#comment-16859850
]
Koen De Groote edited comment on SOLR-13533 at 6/10/19 9:20 AM:
----------------------------------------------------------------
No worries.
{quote}My personal take on this though is that unless they are showing up in a
profiler under real load fixing these isn't worth it.
{quote}
Indeed, real situations with real load are the ones that should be looked at
first.
I'm fully expecting some of these PR's to receive the response of "this is not
a priority, refused".
I'll offer them anyway though. Unless it takes people's time. Which reminds me,
again, please nobody review this on their working hours, on the time they would
actually spend on features for this or another project they could be getting
paid for. I added that as clarification again to the original post.
was (Author: koendg):
No worries.
{quote}My personal take on this though is that unless they are showing up in a
profiler under real load fixing these isn't worth it.
{quote}
Indeed, real situations with real load are the ones that should be looked at
first.
I'm fully expecting some of these PR's to receive the response of "this is not
a priority, refused".
I'll offer them anyway though. Unless it takes people's time. Which reminds me,
again, please nobody review this on their working hours, on the time they would
actually spend on features for this or another project they could be getting
paid for.
> Code Cleanup - Performance
> --------------------------
>
> Key: SOLR-13533
> URL: https://issues.apache.org/jira/browse/SOLR-13533
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Koen De Groote
> Priority: Trivial
> Labels: performance
>
> EDIT: Again, to clarify, please don't bother yourself with this ticket on
> company time, on personal time you could be working on something that makes
> you money or improves the product for your feature personally.
>
> This entire ticket is an afterthough. A look back at the code base that most
> people don't have the time for.
> ---------
>
> Code cleanup as suggested by static analysis tools. Will be done in my spare
> time.
> If someone reviews this, please also do not take up actual time from your
> work to do that. I do not wish to take away from your working hours.
>
> These are simple, trivial things, that were probably overlooked or not even
> considered(which isn't an accusation or something negative). But also stuff
> that the Java compiler/JIT won't optimize on its own.
>
> That's what static analysis tool are good for: picking stuff like that up.
>
> I'm talking about Intellij's static code analysis. Facebook's "Infer" for
> Java. Google's "errorprone", etc...
> These are the kinds of things that, frankly, for the people actually working
> on real features, are very time consuming, not even part of the feature, and
> have a very low chance of actually turning up a real performance issue.
> So I'm opting to have a look at the results of these tools and implementing
> the sensible stuff and if something bigger pops up I'll make a separate
> ticket for those things individually.
>
> Creating this ticket so I can name a branch after it.
>
> The only questions I have are: since the code base is so large, do I apply
> each subject to all parts of it? Or only core? How do I split it up?
> Do I make multiple PRs with this one ticket? Or do I make multiple tickets
> and give each their own PR?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
