KoenDG commented on a change in pull request #707: Use append() when
StringBuilder is being used, instead of regular concat.
URL: https://github.com/apache/lucene-solr/pull/707#discussion_r291940895
##########
File path:
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/tokenattributes/PartOfSpeechAttributeImpl.java
##########
@@ -80,7 +80,7 @@ private String displayMorphemes(Morpheme[] morphemes) {
if (builder.length() > 0) {
builder.append("+");
}
- builder.append(morpheme.surfaceForm + "/" + morpheme.posTag.name() + "("
+ morpheme.posTag.description() + ")");
+
builder.append(morpheme.surfaceForm).append("/").append(morpheme.posTag.name()).append("(").append(morpheme.posTag.description()).append(")");
Review comment:
While true that it is a micro-optimization, I do believe it is a solid one.
As in, a change that will perform better every single time. Not just in edge
cases. And it is a very small improvement, but an improvement none the less.
And this is only 1 subject.
Making these changes, running the tests, writing the PR took a good 30
minutes(mostly waiting on the tests). For something that isn't work on a
feature. So I perfectly understand nobody wants to put their time in that and I
just feel like seeing how much I can contribute in this fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
