[ 
https://issues.apache.org/jira/browse/LUCENE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Male updated LUCENE-3410:
-------------------------------

    Attachment: LUCENE-3410.patch

Patch with the Iterator back to using booleans.  Going to commit.

> Make WordDelimiterFilter's instantiation more readable
> ------------------------------------------------------
>
>                 Key: LUCENE-3410
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3410
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Chris Male
>            Priority: Minor
>         Attachments: LUCENE-3410.patch, LUCENE-3410.patch
>
>
> Currently WordDelimiterFilter's constructor is:
> {code}
> public WordDelimiterFilter(TokenStream in,
>                                    byte[] charTypeTable,
>                                    int generateWordParts,
>                                    int generateNumberParts,
>                                    int catenateWords,
>                                    int catenateNumbers,
>                                    int catenateAll,
>                                    int splitOnCaseChange,
>                                    int preserveOriginal,
>                                    int splitOnNumerics,
>                                    int stemEnglishPossessive,
>                                    CharArraySet protWords) {
> {code}
> which means its instantiation is an unreadable combination of 1s and 0s.  
> We should improve this by either using a Builder, 'int flags' or an EnumSet.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to