ctargett commented on issue #635: SOLR-13371 improve security chapters in refguide URL: https://github.com/apache/lucene-solr/pull/635#issuecomment-500488108 I don't know how to update PRs from forks outside the main lucene-solr repo or I would fix this myself, but there are 2 problems causing the build to fail. Both of these are in `authentication-and-authorization-plugins.adoc`: * The change to the section heading from "Authentication Plugins" to "Authentication" duplicates section title (it appears in `solr-control-script-reference.adoc`), so one of them needs to change. * I recommended the tag & include macro for the plugin lists but when you did it, you kept the link to the parent Securing Solr page, which triggered this bug: https://github.com/asciidoctor/asciidoctor/issues/2200. Essentially, a page can't have both an `include` to bring in a section of a page and also link to that same page. The bug is technically fixed, but we can't use that version yet due to SOLR-12786. Consequently the link to the Securing Solr page in the Audit Logging section is actively broken. Since the link only goes to a sentence or two that point people at the Audit Logging page, why not just point people at the Audit Logging page?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
