[ https://issues.apache.org/jira/browse/LUCENE-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860305#comment-16860305 ]
Alan Woodward commented on LUCENE-8849: --------------------------------------- +1 > DocValuesRewriteMethod.visit should visit the MTQ > ------------------------------------------------- > > Key: LUCENE-8849 > URL: https://issues.apache.org/jira/browse/LUCENE-8849 > Project: Lucene - Core > Issue Type: Bug > Components: core/search > Reporter: David Smiley > Priority: Minor > > The DocValuesRewriteMethod implements the QueryVisitor API (visit method) in > a way that surprises me. It does not visit the wrapped MTQ query. Shouldn't > it? Here is what I think it should do, similar to other query wrappers: > {code:java} > @Override > public void visit(QueryVisitor visitor) { > query.visit(visitor.getSubVisitor(BooleanClause.Occur.MUST, this)); > } > {code} > CC [~romseygeek] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org