[
https://issues.apache.org/jira/browse/LUCENE-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860723#comment-16860723
]
ASF subversion and git services commented on LUCENE-8843:
---------------------------------------------------------
Commit 142a20bb0b24b657da8e267a5ebe205f35dc0637 in lucene-solr's branch
refs/heads/master from Alan Woodward
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=142a20b ]
LUCENE-8843: Fix precommit
> Only ignore IOException on dirs when invoking force
> ---------------------------------------------------
>
> Key: LUCENE-8843
> URL: https://issues.apache.org/jira/browse/LUCENE-8843
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other
> Reporter: Jason Tedor
> Priority: Major
> Fix For: master (9.0), 8.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I think the IOException suppression in IOUtils#fsync when fsyncing
> directories is too broad, it suppresses any IOException that occurs in this
> method if isDir is true. For example, it causes exceptions opening
> non-existent directories, if access is denied to the directory, or general
> filesystem errors to be suppressed. To me that feels like it could be
> suppressing application bugs, or at least exceptions an application would
> want to know about. Instead, the IOException suppression should only apply
> after we have successfully opened the directory. I submitted a PR to propose
> a change along these lines: [https://github.com/apache/lucene-solr/pull/706].
> Please let me know what you think.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
