ErickErickson commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-501337149 Jason: I don’t know enough about the “idea” target to know how to set this automagically, but that’s a great idea. Do you want to raise a JIRA? I think I set this up globally somehow because no matter how often I execute the ant target it doesn’t reformat everything, just changed lines. But it’s trappy as it stands so +1 to changing it. Erick > On Jun 12, 2019, at 8:38 AM, Jason Gerlowski <notificati...@github.com> wrote: > > PR looks good to me. Sorry for my tardiness in reviewing it. > > I have some qualms about introducing a new test base class entirely as this PR does. Our test-base situation is already quite jumbled and there's a lot of developer confusion around when each test-case should be used. There's also been some recent movement towards randomizing the SolrJ RequestWriter in one of the existing test bases. So it's hard to say whether adding a new test-base-class will hold up long term. But I don't want to let the perfect get in the way of the good here - especially since this PR adds some awesome test coverage for atomic updates of a large variety of field types. > > If Noble gets a chance to review #681 I'll circle back and merge this. (Assuming he doesn't beat me to it). > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
