s1monw commented on issue #716: LUCENE-8853: Try parsing original file extension from tmp file URL: https://github.com/apache/lucene-solr/pull/716#issuecomment-501675776 > Or, maybe we could instead require anywhere in Lucene that creates temp files to preserve the final extension in the naming of its temp file, and fix our atomic rename to enforce that if it's renaming a tmp file the extensions must match? It's not too many places where we create temp files? I don't think we should have such a restriction just for FileSwitchDirectory. I'd rather deprecate it and build a better alternative for situations where we want to use NIOFS by default and only mmap some parts etc.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
