cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second 
grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#discussion_r293817823
 
 

 ##########
 File path: 
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
 ##########
 @@ -232,6 +233,47 @@ public void prepare(ResponseBuilder rb) throws IOException
     }
   }
 
+  // check if prefix is a prefix of the array
+  private static boolean isPrefix(SortField[] prefix, SortField[] array){
 
 Review comment:
   There's an existing 
[ArrayUtil](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java)
 class, I wonder if it might welcome a (generic) version of this method. What 
do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to