[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864097#comment-16864097
]
Atri Sharma commented on LUCENE-8855:
-------------------------------------
+1, important change!
I had a few comments/questions:
1) Can we make sizeOfObject method a bit more modular? I understand the idea
behind it, but it would be great if we could make it a bit more granular.
2) Should IntervalsQuery also account for the sizes of the sources?
On a side note, I am wondering if it makes sense to make RamUsageEstimator use
QueryVisitor API instead of iterating over all possible types of object types.
We would need to enhance QueryVisitor API to introduce a semantic of visiting
an Accountable object, but that should be a trivial change.
Of course, that is an orthogonal issue, and I will open a Jira for that.
Overall, +1 from me.
> Add Accountable to Query implementations
> ----------------------------------------
>
> Key: LUCENE-8855
> URL: https://issues.apache.org/jira/browse/LUCENE-8855
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Attachments: LUCENE-8855.patch, LUCENE-8855.patch
>
>
> Query implementations should also support {{Accountable}} API in order to
> monitor the memory consumption e.g. in caches where either keys or values are
> {{Query}} instances.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
