dsmiley commented on a change in pull request #724: SOLR-13523: Atomic Update
results in NullPointerException
URL: https://github.com/apache/lucene-solr/pull/724#discussion_r294084826
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java
##########
@@ -1970,6 +1970,14 @@ public boolean savesChildDocRelations() {
if (!isUsableForChildDocs()) {
return false;
}
+
+ // can not be null, since IndexSchema#isUsableForChildDocs returned true
+ FieldType rootType = getFieldTypeNoEx(ROOT_FIELD_NAME);
+ if (!rootType.hasProperty(FieldProperties.STORED)) {
Review comment:
I don't think we should add this constraint; the nest path field is plenty
useful with root stored=false. It enables the child doc transformer to return
a nested structure. It enables queries to use the index of the nest path to
constraint results. And *some* atomic updates are possible that involve nested
documents -- so long as the top/parent document provided is a root document.
Such an atomic update might add or update children.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
