dsmiley commented on a change in pull request #633: LUCENE-8753 UniformSplit
PostingsFormat
URL: https://github.com/apache/lucene-solr/pull/633#discussion_r294132381
##########
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.java
##########
@@ -291,23 +293,263 @@ public void seekExact(BytesRef term, TermState state) {
throw new UnsupportedOperationException();
}
- //TODO this approach is a hack to reuse complex code in AutomatonTermsEnum.
How to make ATE's logic more reusable?
- protected static class AutomatonNextTermCalculator extends
AutomatonTermsEnum {
+ //This is a copy of AutomatonTermsEnum. Since it's an inner class, the
outer class can
Review comment:
@jpountz as you asked, I forked AutomatonTermsEnum into UniformSplit's
IntersectBlockReader, and undid the minor change in ATE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
