bruno-roustant commented on a change in pull request #633: LUCENE-8753
UniformSplit PostingsFormat
URL: https://github.com/apache/lucene-solr/pull/633#discussion_r294172183
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80Codec.java
##########
@@ -91,7 +91,11 @@ public Lucene80Codec() {
* flushed/merged segments.
*/
public Lucene80Codec(Mode mode) {
- super("Lucene80");
+ this("Lucene80", mode);
+ }
+
+ protected Lucene80Codec(String name, Mode mode) {
+ super(name);
Review comment:
Two points here:
The binary search inside the block allowed the posting format to improve the
seek performance significantly without increasing the size of the FST. Indeed
we can have larger blocks for same seek speed, so the FST size is smaller since
there are less leaves.
We do use the API for Lucene50PostingsReader.postings(). This is a public
method, but unfortunately it internally casts the TermState param to an
internal IntBlockTermState. Maybe it would be cleaner for this API to have a
public interface for IntBlockTermState, or make it public since its fields are
accessed directly. That way we wouldn't have to have a class in this package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
