[
https://issues.apache.org/jira/browse/LUCENE-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866133#comment-16866133
]
Robert Muir commented on LUCENE-8866:
-------------------------------------
Simple patch, I didn't move any code around, just removed the external dep.
> Remove ICU dependency of kuromoji tools/test-tools
> --------------------------------------------------
>
> Key: LUCENE-8866
> URL: https://issues.apache.org/jira/browse/LUCENE-8866
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Priority: Major
> Attachments: LUCENE-8866.patch
>
>
> The tooling stuff has an off-by-default option to normalize entries,
> currently using the ICU api.
> But I think since its off-by-default, and just doing NFKC normalization at
> dictionary-build-time, its a better tradeoff to use the JDK here?
> I would rather remove the ICU dependency for the tooling and look at
> simplifying the build to have less modules (e.g. investigate moving the
> tooling and tests into src/java and src/tools, so that [~msoko...@gmail.com]
> new tests in LUCENE-8863 are running by default, dictionary tool is shipped
> as a commandline tool in the JAR, etc)
> "ant regenerate" should be enough to prevent any chicken-and-eggs in the
> dictionary construction code, so I don't think we need separate modules to
> enforce it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
