[
https://issues.apache.org/jira/browse/LUCENE-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866302#comment-16866302
]
ASF subversion and git services commented on LUCENE-8853:
---------------------------------------------------------
Commit fb6e28d9f1ea016a8c937f15c8043b0684cf77dd in lucene-solr's branch
refs/heads/master from Simon Willnauer
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=fb6e28d ]
LUCENE-8853: Try parsing original file extension from tmp file (#716)
FileSwitchDirectory fails if the tmp file are not in the same directory
as the file it's renamed to. This is correct behavior but breaks with
tmp files used with index sorting. This change tries best effort to find
the right extension directory if the file ends with `.tmp`
> FileSwitchDirectory is broken if temp outputs are used
> ------------------------------------------------------
>
> Key: LUCENE-8853
> URL: https://issues.apache.org/jira/browse/LUCENE-8853
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Simon Willnauer
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> FileSwitchDirectory basically doesn't work if tmp output are used for files
> that are explicitly mapped with extensions. here is a failing test:
> {code}
> 16:49:40 [junit4] Suite:
> org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest
> 16:49:40 [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=BlendedInfixSuggesterTest
> -Dtests.method=testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch
> -Dtests.seed=16D8C93DC8FE5192 -Dtests.slow=true -Dtests.badapples=true
> -Dtests.locale=pt-LU -Dtests.timezone=US/Michigan -Dtests.asserts=true
> -Dtests.file.encoding=ISO-8859-1
> 16:49:40 [junit4] ERROR 0.05s J1 |
> BlendedInfixSuggesterTest.testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch
> <<<
> 16:49:40 [junit4] > Throwable #1:
> java.nio.file.AtomicMoveNotSupportedException: _0.fdx__0.tmp -> _0.fdx:
> source and dest are in different directories
> 16:49:40 [junit4] > at
> __randomizedtesting.SeedInfo.seed([16D8C93DC8FE5192:20E180A9490374CE]:0)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.FileSwitchDirectory.rename(FileSwitchDirectory.java:201)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.MockDirectoryWrapper.rename(MockDirectoryWrapper.java:231)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.LockValidatingDirectoryWrapper.rename(LockValidatingDirectoryWrapper.java:56)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.TrackingDirectoryWrapper.rename(TrackingDirectoryWrapper.java:64)
> 16:49:40 [junit4] > at
> org.apache.lucene.store.FilterDirectory.rename(FilterDirectory.java:89)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.SortingStoredFieldsConsumer.flush(SortingStoredFieldsConsumer.java:56)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DefaultIndexingChain.flush(DefaultIndexingChain.java:152)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DocumentsWriterPerThread.flush(DocumentsWriterPerThread.java:468)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DocumentsWriter.doFlush(DocumentsWriter.java:555)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.DocumentsWriter.flushAllThreads(DocumentsWriter.java:722)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.IndexWriter.prepareCommitInternal(IndexWriter.java:3199)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:3444)
> 16:49:40 [junit4] > at
> org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:3409)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.commit(AnalyzingInfixSuggester.java:345)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.build(AnalyzingInfixSuggester.java:315)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest.getBlendedInfixSuggester(BlendedInfixSuggesterTest.java:125)
> 16:49:40 [junit4] > at
> org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest.testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch(BlendedInfixSuggesterTest.java:79)
> 16:49:40 [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 16:49:40 [junit4] > at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 16:49:40 [junit4] > at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 16:49:40 [junit4] > at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> 16:49:40 [junit4] > at
> java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
