[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866423#comment-16866423 ]
Atri Sharma commented on LUCENE-8862: ------------------------------------- [~jpountz] What are your thoughts on the options of implementing this approach, then? The way I see it, we could either add a default method to Collector interface to accept the memory accounting object and let the Collector implementation deal with how it wants to account for memory consumption. The other way is to add the introduce the visitor API, but I agree that it has its caveats. The objective is to have a generic collector-level interface that can be used to build constructs for monitoring and limiting memory usage per query. Implementing Accountable per Collector will not give us that flexibility without a couple of instanceof checks, IIUC. Thoughts? > Collector Level Dynamic Memory Accounting > ----------------------------------------- > > Key: LUCENE-8862 > URL: https://issues.apache.org/jira/browse/LUCENE-8862 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Atri Sharma > Priority: Major > > Inspired from LUCENE-8855, I am thinking of adding a new interface which > tracks dynamic memory used by Collectors. This shall allow users to get an > accountability as to the memory usage of their Collectors and better plan > their resource capacity. This shall also allow us to add Collector level > limits for memory usage, thus allowing users a finer control over their > resources. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org