msokolov commented on a change in pull request #722: LUCENE-8863: handle some
edge cases in Kuromoji DictionaryBuilder, en…
URL: https://github.com/apache/lucene-solr/pull/722#discussion_r294967154
##########
File path: lucene/analysis/kuromoji/build.xml
##########
@@ -136,8 +136,8 @@
</compile>
</target>
- <target name="test-tools" depends="compile-tools-tests">
- <test-macro dataDir="src/tools/test"
junit.classpath="tools.test.classpath"/>
+ <target name="test-tools" depends="install-junit4-taskdef,
compile-tools-tests">
+ <test-macro testsDir="${build.dir}/classes/tools-test"
workDir="src/tools/test" junit.classpath="tools.test.classpath"/>
Review comment:
yeah, this felt kind of like a dusty corner where things would easily get
lost. I'm just learning about the tools and modules concepts in lucene builds.
It seems fine to have the builder available in the analysis jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
