msokolov commented on issue #728: LUCENE-8867: Store point with cardinality for low cardinality leaves URL: https://github.com/apache/lucene-solr/pull/728#issuecomment-503261067 We discussed this today - thanks for the change! I'm not familiar with this area of the code, and not really qualified to assess it, but I did notice there are no tests with the patch. I guess we are supporting existing functionality, but are we sure that the existing tests are covering the different cardinalities?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
