[ 
https://issues.apache.org/jira/browse/SOLR-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867891#comment-16867891
 ] 

Cao Manh Dat commented on SOLR-12988:
-------------------------------------

Hi [~hossman] I kinda think we are misunderstanding each others here. 

{quote}
that doesn't even fucking compile with java8
{quote}
Firstly, I don't see any problem with compiling branch_8x on java8 locally.

Secondly, I rushed the commit to revert changes back to it used to be + minimal 
checks so Jenkins will become happy. THEN we can continue doing what we should 
do after discussion.

Thirdly, I quite understand your idea now, so we should call {{assumFalse()}} 
in {{SSLTestConfig}} whenever SSL is enabled on Java 11 -> 11.0.2. Luckily that 
it still matches with issue's name and we do not need to change issue name 
(again).

> Skip running tests with SSL on Java 11 to 11.0.2
> ------------------------------------------------
>
>                 Key: SOLR-12988
>                 URL: https://issues.apache.org/jira/browse/SOLR-12988
>             Project: Solr
>          Issue Type: Test
>            Reporter: Hoss Man
>            Assignee: Cao Manh Dat
>            Priority: Major
>              Labels: Java11, Java12
>         Attachments: SOLR-13413.patch
>
>
> HTTPCLIENT-1967 indicates that HttpClient can't be used properly with 
> TLSv1.3. It caused some test failures below, therefore we should skip running 
> tests with SSL on Java 11 to 11.0.2.
> TestMiniSolrCloudClusterSSL.testSslWithCheckPeerName seems to fail 100% of 
> the time when run with java11 (or java12), regardless of seed, on both master 
> & 7x.
> The nature of the problem and the way our htp stack works suggests it *may* 
> ultimately be a jetty bug (perhaps related to [jetty 
> issue#2711|https://github.com/eclipse/jetty.project/issues/2711]?)
> *HOWEVER* ... as far as i can tell, whatever the root cause is, seems to have 
> been fixed on the {{jira/http2}} branch (as of 
> 52bc163dc1804c31af09c1fba99647005da415ad) which should hopefully be getting 
> merged to master soon.
> Filing this issue largely for tracking purpose, although we may also want to 
> use it for discussions/considerations of other backports/fixes to 7x



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to