On Wed, Sep 7, 2011 at 8:13 PM, Yonik Seeley <[email protected]> wrote: > On Wed, Sep 7, 2011 at 1:53 PM, Simon Willnauer > <[email protected]> wrote: >> wow - from you last comment on SOLR-2700 this commit comes kid of >> unexpected. > > I did say in the previous comment "OK, I think we're getting close to > committing now." > Then I found a bug. Then I fixed it and committed. > I felt more comfortable committing since this feature is not enabled by > default. > Non-optimal implementations should be fine, as long as we try to get > the high level APIs right (/get in this case). ok this make sense to me while I would have expected followup issues and an announcement on the issue that you are going to commit. From your comment I was actually waiting for a fixed patch. Can you create followup issues for this to make it more optimal. Otherwise this might get forgotten and stay sub-optimal.
Simon > > -Yonik > http://www.lucene-eurocon.com - The Lucene/Solr User Conference > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
