dsmiley commented on a change in pull request #723: SOLR-13545: AutoClose
stream in ContentStreamUpdateRequest
URL: https://github.com/apache/lucene-solr/pull/723#discussion_r295977523
##########
File path:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java
##########
@@ -724,10 +736,18 @@ public void testStreamingRequest() throws Exception {
client.commit();
QueryResponse rsp = client.query( new SolrQuery( "*:*") );
Assert.assertEquals(0, rsp.getResults().getNumFound());
+ // Create a copy of the file, which can be deleted after uploading.
+ // If the stream isn't closed, the file deletion will fail on Windows,
+ // though it will succeed on linux regardless
Review comment:
We do have CI infrastructure that runs on Windows, so a test that only fails
on Windows is not useless. Nonetheless, it's better if it can test everywhere,
though not essential in my mind if it's hard in this case. Your call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
