colvinco commented on issue #723: SOLR-13545: AutoClose stream in ContentStreamUpdateRequest URL: https://github.com/apache/lucene-solr/pull/723#issuecomment-504691784 I saw @mkhludnev has patched the ContentStreamUpdateRequest and covered it in the test. So I don't mind dropping this totally. I'll offer this as a way of testing that the StreamingUpdateRequest also closes its underlying stream... I made ContentStreamUpdateRequest and StreamingUpdateRequest both use a common ContentWriter, which can be tested on its own, and asserted that both of the request classes use that ContentWriter. I don't like writing tests that are this closely coupled with the implementation, but it seemed like a reasonable compromise. But like I say, I don't mind dropping this
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
