thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-504697943 > Hey Thomas, the code compiles and passes `precommit` now, which is a good step, but it looks like there are some test failures that this PR introduces. It looks like they're related to a change you made to SolrJettyTestBase. See one of my inline comments for more details. I also asked a few questions that I'd be interested in answers to before merging. > No problem, code can only be getting better, and there are always reasons when questions are asked. > Let me know if you're having any trouble reproducing those test failures locally. > No troubles but as i mentioned before, working with the generated eclipse project is really a pain! > Sorry that this has gone back and forth so many rounds. I imagine you're likely frustrated. But we're very close to getting this merged. Thanks for your patience and hard work on this. You don't have to be sorry about that, on my side we are using solr server pretty much, so i am always interested in better test coverage an cleaner code base.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
