jpountz commented on a change in pull request #730: LUCENE-8868: New storing strategy for BKD tree leaves with low cardinality URL: https://github.com/apache/lucene-solr/pull/730#discussion_r296587865
########## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ########## @@ -80,7 +80,8 @@ //public static final int VERSION_CURRENT = VERSION_START; public static final int VERSION_LEAF_STORES_BOUNDS = 5; public static final int VERSION_SELECTIVE_INDEXING = 6; - public static final int VERSION_CURRENT = VERSION_SELECTIVE_INDEXING; + public static final int VERSION_LOW_CARDINALITY_LEAVES= 7; Review comment: Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
