[ 
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873207#comment-16873207
 ] 

Atri Sharma commented on LUCENE-8811:
-------------------------------------

Thanks [~romseygeek] for pushing!

 

A small nit: I think git somehow botched up the patch during commit ? (I see 
your name as both author and committer).

> Add maximum clause count check to IndexSearcher rather than BooleanQuery
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-8811
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8811
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: 8.2
>
>         Attachments: LUCENE-8811.patch, LUCENE-8811.patch, LUCENE-8811.patch, 
> LUCENE-8811.patch, LUCENE-8811.patch, LUCENE-8811.patch
>
>
> Currently we only check whether boolean queries have too many clauses. 
> However there are other ways that queries may have too many clauses, for 
> instance if you have boolean queries that have themselves inner boolean 
> queries.
> Could we use the new Query visitor API to move this check from BooleanQuery 
> to IndexSearcher in order to make this check more consistent across queries? 
> See for instance LUCENE-8810 where a rewrite rule caused the maximum clause 
> count to be hit even though the total number of leaf queries remained the 
> same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to