nknize commented on a change in pull request #726: LUCENE-8632: New XYShape 
Field and Queries for indexing and searching general cartesian geometries
URL: https://github.com/apache/lucene-solr/pull/726#discussion_r297775659
 
 

 ##########
 File path: lucene/sandbox/src/java/org/apache/lucene/document/LatLonShape.java
 ##########
 @@ -54,14 +50,7 @@
  *
  * @lucene.experimental
  */
-public class LatLonShape {
-  static final int BYTES = Integer.BYTES;
-
-  protected static final FieldType TYPE = new FieldType();
-  static {
-    TYPE.setDimensions(7, 4, BYTES);
-    TYPE.freeze();
-  }
+public class LatLonShape extends ShapeField {
 
 Review comment:
   Not at all. Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to