[ 
https://issues.apache.org/jira/browse/LUCENE-8890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874763#comment-16874763
 ] 

ASF subversion and git services commented on LUCENE-8890:
---------------------------------------------------------

Commit a8fef9a94f04634d3c753faf0caea40ac844a8b6 in lucene-solr's branch 
refs/heads/branch_8x from Adrien Grand
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a8fef9a ]

LUCENE-8890: Fix compilation.


> Parallel Iteration of Lists
> ---------------------------
>
>                 Key: LUCENE-8890
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8890
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Sven Amann
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: master (9.0), 8.2
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Solr/contrib/analysis-extras contains the class `BooleanWeight`, which 
> maintains two lists that are repeatedly iterated over in parallel. While both 
> lists do have the same length, this is not immediately obvious from the 
> locations the iterate them. A future change may lead to the lists getting our 
> of sync, which would break the iterations. Moreover, there is no established 
> language feature for iterating two lists, which is why the iteration is 
> implemented differently in various locations throughout the class.
> I created a patch that joins the two lists into one, which simplifies the 
> iteration, unifies the implementation in all places, and prevents that the 
> two lists get out of sync without becoming aware of the parallel iterations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to