jpountz commented on a change in pull request #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#discussion_r298529210
########## File path: lucene/MIGRATE.txt ########## @@ -182,3 +182,9 @@ to concurrent changes. ## maxClausesCount moved from BooleanQuery To IndexSearcher (LUCENE-8811) ## IndexSearcher now performs max clause count checks on all types of queries (including BooleanQueries). This led to a logical move of the clauses count from BooleanQuery to IndexSearcher. + +## TopDocs.merge shall no longer allow setting of shard indices ## + +TopDocs.merge's API has been changed to stop allowing passing in a parameter to indicate if it should +set shard indices for hits as they are seen during the merge process. This is done to simplify the API +to be more dynamic in terms of passing in custom tie breakers Review comment: Maybe say explicitly that if shard indices should be used for tie-breaking then they should be set on the ScoreDoc objects before calling TopDocs#merge? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
