gerlowskija commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507056931 Hmm, I'm still seeing test-failures with this PR that look pretty related to the changes: ``` [junit4] Tests with failures [seed: AD13CA5C9C515876]: [junit4] - org.apache.solr.update.processor.AbstractAtomicUpdatesMultivalueTest.initializationError [junit4] - org.apache.solr.cloud.TestCloudConsistency.testOutOfSyncReplicasCannotBecomeLeaderAfterRestart [junit4] - org.apache.solr.handler.tagger.EmbeddedSolrNoSerializeTest.testTag [junit4] - org.apache.solr.handler.tagger.EmbeddedSolrNoSerializeTest.testAssertTagStreamingWithSolrTaggerRequest ``` TestCloudConsistency might just be flaky, but the other ones seem relevant at least. Are you able to see these locally, or is it just me? To reproduce them, I'm checking out the latest `master`, and then cherry-picking your commits on top. The commands look like: ``` git fetch -f origin pull/665/head:SOLR_13539_thomas # Checkout this PR branch locally git checkout master git pull # Make sure I've got latest commits on master git checkout -b SOLR_13539 git cherry-pick fec20285eb02890043ececf9c71a1dbeaceaf051 git cherry-pick b378868143bf01cb3d2a53665ff10c564b593189 ant test ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
