mikemccand commented on a change in pull request #758: LUCENE-8833: Add a
#load() method to IndexInput to allow preloading file content into physical
memory
URL: https://github.com/apache/lucene-solr/pull/758#discussion_r299550540
##########
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##########
@@ -202,24 +201,6 @@ public boolean getUseUnmap() {
return useUnmapHack;
}
- /**
- * Set to {@code true} to ask mapped pages to be loaded
- * into physical memory on init. The behavior is best-effort
- * and operating system dependent.
- * @see MappedByteBuffer#load
- */
- public void setPreload(boolean preload) {
Review comment:
We lose the ability to always pre-load here? But one can always make a
small wrapper like `MMapDirectoryFactory` does; maybe add that as an example to
`MIGRATE.txt`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
