iverase commented on a change in pull request #762: LUCENE-8903: Add
LatLonShape point query
URL: https://github.com/apache/lucene-solr/pull/762#discussion_r300545922
##########
File path: lucene/sandbox/src/java/org/apache/lucene/document/LatLonShape.java
##########
@@ -94,9 +94,18 @@ private LatLonShape() {
return new Field[] {new LatLonTriangle(fieldName, lat, lon, lat, lon, lat,
lon)};
}
+ /** create a query to find all indexed shapes that comply the {@link
QueryRelation} with the provided point
+ **/
+ public static Query newPointQuery(String field, QueryRelation queryRelation,
double lat, double lon) {
Review comment:
Not sure, I would keep it like that for two reasons:
- Keep it consistent with all the other queries in LatLonShape
- You can build queries like give me all my shapes that do not contain this
point. For Within it becomes a term query matching all indexed point which
encoded value are equal to the encoded value of the query.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
