atris commented on issue #754: LUCENE-8875: Introduce Optimized Collector For Large Number Of Hits URL: https://github.com/apache/lucene-solr/pull/754#issuecomment-509525838 @jpountz Thanks, I have fixed the comments. The reason I did not use the BooleanQuery for the PQ build and not build tests was because those tests only exercise whether the priority queue was built or not which is dependent on the number of hits collected vs number of hits requested. However, per your suggestion, I have fixed the same.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
