mikemccand commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#discussion_r301508927
########## File path: lucene/MIGRATE.txt ########## @@ -190,3 +190,10 @@ set shard indices for hits as they are seen during the merge process. This is do to be more dynamic in terms of passing in custom tie breakers. If shard indices are to be used for tie breaking docs with equal scores during TopDocs.merge, then it is mandatory that the input ScoreDocs have their shard indices set to valid values prior to calling TopDocs.merge + +## TopDocsCollector Shall Throw IllegalStateException For Malformed Arguments ## + +TopDocsCollector shall no longer return an empty TopDocs for malformed arguments. +Rather, an IllegalStateException shall be thrown. This is introduced for better Review comment: `IllegalArgumentException`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
