[ 
https://issues.apache.org/jira/browse/LUCENE-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881982#comment-16881982
 ] 

Adrien Grand commented on LUCENE-8907:
--------------------------------------

I don't like 2, it feels too breaking to me for a minor release. I like 1 
better but then I think we should also fail if an analysis factory has a NAME 
constant that is not the same as the name that would be derived from the class 
name?

Another option could be to revert from 8.x. In any case we should add migration 
instructions to lucene/MIGRATE.txt on master.

bq. some warning messages would be helpful

We never log from Lucene since this is a library.

> Provide backward compatibility for loading analysis factories
> -------------------------------------------------------------
>
>                 Key: LUCENE-8907
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8907
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/analysis
>            Reporter: Tomoko Uchida
>            Priority: Blocker
>
> The changes in LUCENE-8778 have breaking changes in the analysis factory 
> interface and  custom factories implemented by users / 3rd parties will be 
> affected. We need to keep some backwards compatibility during 8.x.
> Please see the discussion in SOLR-13593 for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to