[ 
https://issues.apache.org/jira/browse/LUCENE-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887340#comment-16887340
 ] 

Atri Sharma commented on LUCENE-8924:
-------------------------------------

I see. Should we make this more explicit and robust then? For E.g., since we do 
not explicitly maintain a sort order but rely on the key set to do the right 
thing, a change from Collections.unModifiableSet to Set.copyOf breaks this 
assertion in checkIndex (since Ser.copyOf explicitly calls out that there is no 
guarantee in the order of traversal)

> Remove Fields Order Checks from CheckIndex?
> -------------------------------------------
>
>                 Key: LUCENE-8924
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8924
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Atri Sharma
>            Priority: Major
>
> CheckIndex checks the order of fields read from the FieldsEnum for the 
> posting reader. Since we do not explicitly sort or use a sorted data 
> structure to represent keys (atleast explicitly), and no FieldsEnum depends 
> on the order apart from MultiFieldsEnum, which no longer exists.
>  
> Should we remove the check?



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to