jpountz commented on a change in pull request #796: LUCENE-8927: Set.copyOf and
Set.of instead of Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#discussion_r305266078
##########
File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
##########
@@ -422,6 +422,10 @@ synchronized boolean contains(String fieldName,
DocValuesType dvType) {
}
}
+ synchronized Set<String> getFieldNames() {
+ return Set.copyOf(nameToNumber.keySet());
+ }
Review comment:
we should not resurrect this method that we just removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
