[
https://issues.apache.org/jira/browse/SOLR-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103005#comment-13103005
]
Steven Rowe commented on SOLR-2756:
-----------------------------------
bq. lucene-core dependency should be removed
I don't think it can be. When I tried, compilation fails:
{noformat}
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[19,29]
package org.apache.lucene.util does not exist
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[353,38]
cannot find symbol
symbol : class PriorityQueue
location: class org.apache.solr.common.util.ConcurrentLRUCache<K,V>
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[320,24]
cannot find symbol
symbol : method size()
location: class org.apache.solr.common.util.ConcurrentLRUCache.PQueue
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[320,58]
cannot find symbol
symbol : method size()
location: class org.apache.solr.common.util.ConcurrentLRUCache.PQueue
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[321,56]
cannot find symbol
symbol : method pop()
location: class org.apache.solr.common.util.ConcurrentLRUCache.PQueue
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[358,6]
non-static variable super cannot be referenced from a static context
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[358,11]
cannot find symbol
symbol : method initialize(int)
location: class java.lang.Object
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[359,13]
cannot find symbol
symbol : method getHeapArray()
location: class org.apache.solr.common.util.ConcurrentLRUCache.PQueue
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[365,4]
method does not override or implement a method from a supertype
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[373,10]
non-static method size() cannot be referenced from a static context
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[374,8]
cannot find symbol
symbol : method add(java.lang.Object)
location: class org.apache.solr.common.util.ConcurrentLRUCache.PQueue
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[376,17]
non-static method size() cannot be referenced from a static context
\svn\lucene\dev\branches\branch_3x\solr\solrj\src\java\org\apache\solr\common\util\ConcurrentLRUCache.java:[379,8]
cannot find symbol
symbol : method updateTop()
location: class org.apache.solr.common.util.ConcurrentLRUCache.PQueue
{noformat}
> SolrJ maven dependencies are faulty; needless dependency on lucene-core
> -----------------------------------------------------------------------
>
> Key: SOLR-2756
> URL: https://issues.apache.org/jira/browse/SOLR-2756
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 3.3
> Reporter: David Smiley
> Priority: Minor
>
> I included a SolrJ 3.3 dependency into a new project and I noticed needless
> dependencies transitive show up.
> Here is a subset of the output from mvn dependency:tree:
> {noformat}
> [INFO] +- org.apache.solr:solr-solrj:jar:3.3.0:compile
> [INFO] | +- org.apache.lucene:lucene-core:jar:3.3.0:compile
> [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile
> [INFO] | | \- commons-codec:commons-codec:jar:1.2:compile
> [INFO] | +-
> org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:compile
> [INFO] | +- org.apache.zookeeper:zookeeper:jar:3.3.1:compile
> [INFO] | | +- log4j:log4j:jar:1.2.15:compile
> [INFO] | | | \- javax.mail:mail:jar:1.4:compile
> [INFO] | | | \- javax.activation:activation:jar:1.1:compile
> [INFO] | | \- jline:jline:jar:0.9.94:compile
> [INFO] | \- org.codehaus.woodstox:wstx-asl:jar:3.2.7:compile
> [INFO] | \- stax:stax-api:jar:1.0.1:compile
> {noformat}
> Clearly there is an inconsistency with solr/dist/solrj-lib and this list.
> * lucene-core dependency should be removed
> * AFAIK, geronimo-stax-api and wstx-asl are only needed for Java 1.5. Right?
> These can be put in a maven profile activated by jdk1.5.
> * zookeeper dependency should be removed. Is this used in Solr 4? Even if it
> is, it strikes me as an optional dependency.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
