Thanks, Steve. So it's been discussed and seems possible, but needs work. Would be nice!
On Fri, Jul 19, 2019, 8:01 PM Steve Rowe <[email protected]> wrote: > Hi Mike, > > I don't think so, based on this SOLR-10912 comment[1] from Allen > Wittenauer, who works on Yetus: > > Github PR support is sort of there. > > test-patch does. It can take either a github PR directly on the command > line or passed via a JIRA. If it gets told to test a JIRA that references a > github PR, it will defer to the PR as the source of the patch. In other > words, if a JIRA issue references a github PR and has a patch attached, it > will use the github PR and ignore the attachments. > > However! > > The job on Jenkins that feeds test-patch is NOT github aware. The original > version was built before github integration existed. To make matters worse, > that code was locked away in a repository no one really had access to > modify. As of a month or so ago, that code is now part of Apache Yetus ( > https://github.com/apache/yetus/blob/master/precommit/jenkins/jenkins-admin.py > ), so there is an opportunity for us to fix this problem and add better > asf<->github integration. > > > jenkins-admin.py has moved here: > https://github.com/apache/yetus/blob/master/precommit/src/main/python/jenkins-admin.py > > and has not been modified since to handle Github PRs. > > Every 10 minutes, ASF Jenkins job > https://builds.apache.org/job/PreCommit-Admin/ invokes jenkins-admin.py, > which triggers builds on these Jenkins jobs for LUCENE and SOLR issues, > respectively: > https://builds.apache.org/view/L/view/Lucene/job/PreCommit-LUCENE-Build > and https://builds.apache.org/view/L/view/Lucene/job/PreCommit-SOLR-Build > . > > > [1] > https://issues.apache.org/jira/browse/SOLR-10912?focusedCommentId=16380775&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16380775 > <https://issues.apache.org/jira/browse/SOLR-10912?focusedCommentId=16380775&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16380775> > > -- > Steve > > > On Jul 19, 2019, at 6:20 PM, Michael Sokolov <[email protected]> wrote: > > Is there a way to have Yetus build a PR as we can do with patch files? > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > <[email protected]> > For additional commands, e-mail: [email protected] > <[email protected]> > > >
