[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892091#comment-16892091 ]
Nicholas Knize commented on LUCENE-8369: ---------------------------------------- Since the merge of XYShape I wanted to quickly resurrect this conversation. Given so much of the {{LatLonShape}} foundation is shared between {{LatLonPoint}} and {{XYShape}} and we have a {{spatial}} module that is basically empty. I tend to agree with [~dsmiley]'s original proposal to refactor {{LatLonPoint}}, {{LatLonShape}}, {{XYShape}}, and all query, support, and util classes currently spread between {{core}} and {{sandbox}} to the {{spatial}} module. We can keep the {{spatial}} module dependency free, and still use {{spatial-extras}} to build on the foundation classes with third-party dependencies. I think the only major ramification is that {{Geo3d}} will have to be updated to depend on the spatial module. But I don't see that as a major blocker. Comments, thoughts, objections? /cc [~mikemccand] [~jpountz] [~rcmuir] [~ivera] > Remove the spatial module as it is obsolete > ------------------------------------------- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial > Reporter: David Smiley > Assignee: David Smiley > Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org