atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-515440912 > > I'm wondering whether we should consider removing this `topDocs` variant which takes a `howMany` parameter. I can't think of a good reason to pass something else than `numHits-start` there? Is there a use-case I'm missing? > > I think it was intended to allow people to "scroll" through hits and "pick" a small subset to get e.g. get the hits from 4th best to 8th best. I agree that there is no concrete use case that comes to mind though, so +1 to removing it Another question is -- what is the expected behaviour when start > size? Should we error out, or return a null topdocs (as we do today), or normalize the start value to be 0?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
