[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893958#comment-16893958 ]
Michael Gibney commented on SOLR-7798: -------------------------------------- [~joel.bernstein], I circled back to this, and squash-rebased [PR 325|https://github.com/apache/lucene-solr/pull/325] on current master. The patch applies cleanly and passes precommit and all tests, so it should be solid. I'm sorry for the false start (in Feb. 2018); if you'd be willing to take another look at this, I think this will now _actually_ be as straightforward as it initially should have been! > Improve robustness of ExpandComponent > ------------------------------------- > > Key: SOLR-7798 > URL: https://issues.apache.org/jira/browse/SOLR-7798 > Project: Solr > Issue Type: Improvement > Components: SearchComponents - other > Reporter: Jörg Rathlev > Assignee: Joel Bernstein > Priority: Minor > Attachments: expand-component.patch, expand-npe.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{ExpandComponent}} causes a {{NullPointerException}} if accidentally > used without prior collapsing of results. > If there are multiple documents in the result which have the same term value > in the expand field, the size of the {{ordBytes}}/{{groupSet}} differs from > the {{count}} value, and the {{getGroupQuery}} method creates an incompletely > filled {{bytesRef}} array, which later causes a {{NullPointerException}} when > trying to sort the terms. > The attached patch extends the test to demonstrate the error, and modifies > the {{getGroupQuery}} methods to create the array based on the size of the > input maps. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org