[
https://issues.apache.org/jira/browse/LUCENE-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898409#comment-16898409
]
ASF subversion and git services commented on LUCENE-8906:
---------------------------------------------------------
Commit 0bebca85577a697d55b7bea79ef933824cae1597 in lucene-solr's branch
refs/heads/branch_8x from Bruno Roustant
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0bebca8 ]
LUCENE-8906: Lucene50PostingsFormat.IntBlockTermState becomes public
(cherry picked from commit 52b5ec8068861d3724c83f63142105b7294cceef)
> Lucene50PostingsReader.postings() casts BlockTermState param to private
> IntBlockTermState
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-8906
> URL: https://issues.apache.org/jira/browse/LUCENE-8906
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: Bruno Roustant
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Lucene50PostingsReader is the public API that offers the postings() method to
> read the postings. Any PostingFormat can use it (as well as
> Lucene50PostingsWriter) to read/write postings.
> But the postings() method asks for a (public) BlockTermState param which is
> internally cast to the private IntBlockTermState. This BlockTermState is
> provided by Lucene50PostingsReader.newTermState().
> public PostingsEnum postings(FieldInfo fieldInfo, BlockTermState termState,
> PostingsEnum reuse, int flags)
> This actually makes impossible to a custom PostingFormat customizing the
> Block file structure to use this postings() method by providing their
> (Int)BlockTermState, because they cannot access the FP fields of the
> IntBlockTermState returned by PostingsReaderBase.newTermState().
> Proposed change:
> * Either make IntBlockTermState public, as well as its fields.
> * Or replace it by an interface in the postings() method. In this case the
> IntBlockTermState fields currently accessed directly would be replaced by
> getter/setter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
