[
https://issues.apache.org/jira/browse/SOLR-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901705#comment-16901705
]
Shalin Shekhar Mangar commented on SOLR-13579:
----------------------------------------------
Thanks [~ab]. This is looking good. I've done a first pass through the design
and code. It took a time to wrap my head around it and your jira comments
describing the use-case and how it works really helped.
I have some initial comments:
# The DefaultResourceManaged has a bug I think. The pool can be created by
createPool and it is scheduled immediately and added to the resourcePools map
with the key being the name of the resource pool. So presumably we can create
multiple pools of the same type which is as per the design. But the
#registerComponent() method gets the pool for the given name and checks that
there are no other pools with the same type? AIUI, there are no checks to see
if the given managed component is actually registered in the other pools of the
same type? This can be easily demonstrated by changing the
TestDefaultResourceManagerPool.testBasic method and adding another pool with
the same type.
# The package-info.java for the managed package can benefit from some of the
design documentation you have added in this Jira.
# There is no v2 api for the /admin/resources?
I'm going to do another pass and try it out and get back to you.
> Create resource management API
> ------------------------------
>
> Key: SOLR-13579
> URL: https://issues.apache.org/jira/browse/SOLR-13579
> Project: Solr
> Issue Type: New Feature
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Attachments: SOLR-13579.patch, SOLR-13579.patch, SOLR-13579.patch,
> SOLR-13579.patch, SOLR-13579.patch, SOLR-13579.patch, SOLR-13579.patch
>
>
> Resource management framework API supporting the goals outlined in SOLR-13578.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
