[
https://issues.apache.org/jira/browse/SOLR-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903103#comment-16903103
]
Andrzej Bialecki commented on SOLR-9658:
-----------------------------------------
Thanks Hoss for the detailed review! I updated the patch to include the changes
after your review:
* fixed ConcurrentLRUCache to sweep by idle time first.
* fixed CleanupThread to not need the additional arg.
* fixed the constructors to preserve back-compat, and fixed
TemplateUpdateProcessorFactory to use original defaults (no maxIdleTime).
* fixed unit tests to not rely on Thread.sleep - this required a bit more
changes in order to expose the eviction listener in a uniform way across cache
impls, plus adding support for artificially "advancing" the time. The new
{{CacheListener}} callback allows us to add more instrumentation later, eg. to
monitor the sweeps by type and collect pre/post sweep stats, etc.
> Caches should have an optional way to clean if idle for 'x' mins
> ----------------------------------------------------------------
>
> Key: SOLR-9658
> URL: https://issues.apache.org/jira/browse/SOLR-9658
> Project: Solr
> Issue Type: New Feature
> Reporter: Noble Paul
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 8.3
>
> Attachments: SOLR-9658.patch, SOLR-9658.patch, SOLR-9658.patch,
> SOLR-9658.patch
>
>
> If a cache is idle for long, it consumes precious memory. It should be
> configurable to clear the cache if it was not accessed for 'x' secs. The
> cache configuration can have an extra config {{maxIdleTime}} . if we wish it
> to the cleaned after 10 mins of inactivity set it to {{maxIdleTime=600}}.
> [~dragonsinth] would it be a solution for the memory leak you mentioned?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
