[
https://issues.apache.org/jira/browse/LUCENE-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904562#comment-16904562
]
Tomoko Uchida commented on LUCENE-8948:
---------------------------------------
OK, in the [ICU factory
documentation|https://lucene.apache.org/core/8_2_0/analyzers-icu/org/apache/lucene/analysis/icu/ICUNormalizer2FilterFactory.html],
it's explicitly documented as follows:
{quote}name: A Unicode Normalization Form, one of 'nfc','nfkc', 'nfkc_cf'.
Default is nfkc_cf.
{quote}
So seems there is no need to worry about changing the parameter to "form" :)
Here is the patch that also includes tests and Javadoc changes:
[^LUCENE-8948.patch]
> Change "name" argument in ICU factories to "form"
> -------------------------------------------------
>
> Key: LUCENE-8948
> URL: https://issues.apache.org/jira/browse/LUCENE-8948
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Priority: Minor
> Attachments: LUCENE-8948.patch
>
>
> {{o.a.l.a.icu.ICUNormalizer2CharFilterFactory}} and
> {{o.a.l.a.icu.ICUNormalizer2FilterFactory}} have "name" arguments to specify
> Unicode Normalization Form. The "name" is vague and it causes problem with
> SOLR-13593.
> "form" would be suitable here instead of "name".
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
