gerlowskija commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-520232283 My apologies Thomas, my gmail filters weren't letting through github notifications and I didn't see this until you pinged me in JIRA. This all looks good to me, except for the whitespace formatting, which we've talked about on other PRs. Github makes it easy to hide introduction/removal of trailing whitespace, but other changes are harder to hide and make the diff noisier to read and harder to review with confidence: adding "final" modifiers to existing variables, breaking up long method signatures onto multiple lines, etc. Would you mind scrubbing some of those changes from this PR? In the meantime, I'm going to start "beasting" (run {{ant test-help}} for info) this PR to make sure that none of the affected tests have any flaky failures. I'll comment again in a day or two with some results. (If you want to help out, you can also run some beast-runs if your machine allows it.) Thanks for your continued patience.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
