jimczi commented on a change in pull request #809: LUCENE-8933: Validate
JapaneseTokenizer user dictionary entry
URL: https://github.com/apache/lucene-solr/pull/809#discussion_r313249640
##########
File path:
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/dict/UserDictionaryTest.java
##########
@@ -77,4 +78,19 @@ public void testRead() throws IOException {
UserDictionary dictionary = TestJapaneseTokenizer.readDict();
assertNotNull(dictionary);
}
+
+ @Test(expected = RuntimeException.class)
Review comment:
Can you use `expectThrows` and check that the message is correct ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
