[ 
https://issues.apache.org/jira/browse/SOLR-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909124#comment-16909124
 ] 

Chris Troullis commented on SOLR-13699:
---------------------------------------

The fix I have was just to basically add another instanceOf check to handle the 
ByteArrayUtf8CharSequence, which I agree is not the best solution. It does seem 
like there have been a number of regressions created by the optimization. I'm 
not sure I understand enough about the intent of the original change to make 
any kind of larger scale refactor.

Let me know if you still think it's worth submitting my patch, or if you'd 
prefer to revisit the design of the original optimization.

> maxChars no longer working as designed on CopyField
> ---------------------------------------------------
>
>                 Key: SOLR-13699
>                 URL: https://issues.apache.org/jira/browse/SOLR-13699
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.7, 7.7.1, 7.7.2, 8.0, 8.0.1, 8.1, 8.2, 7.7.3, 8.1.1, 
> 8.1.2
>            Reporter: Chris Troullis
>            Assignee: Erick Erickson
>            Priority: Major
>
> We recently upgraded from Solr 7.3 to 8.1, and noticed that the maxChars 
> property on a copy field is no longer functioning as designed, while indexing 
> via SolrJ. Per the most recent documentation it looks like there have been no 
> intentional changes as to the functionality of this property, so I assume 
> this is a bug.
>   
>  In debugging the issue, it looks like the bug was caused by SOLR-12992. In 
> DocumentBuilder where the maxChar limit is applied, it first checks if the 
> value is instanceof String. As of SOLR-12992, string values are now coming in 
> as ByteArrayUtf8CharSequence (unless they are above a certain size as defined 
> by JavaBinCodec.MAX_UTF8_SZ), so they are failing the instanceof String 
> check, and the maxChar truncation is not being applied. I am currently not 
> sure if this issue is limited to indexing via SolrJ or if it applies to 
> documents indexed via any means



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to